Source generator tweaks #1178
Merged
Source generator tweaks #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… captured variables, potentially resulting in unintended allocations
… from producing diagnostics
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 241 241
Lines 7700 7703 +3
=======================================
+ Hits 7129 7132 +3
Misses 571 571
Help us with your feedback. Take ten seconds to tell us how you rate us. |
maurei
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following header comment to auto-generated controller classes:
// <auto-generated />The comment instructs other analyzers, such as StyleCop, to skip analyzing such files, so you won't get suggestions or warnings in them.
I've also updated the project to C# 10, so we can use static lambdas to avoid accidental closure allocations.
On my 6-year-old home computer, building the integration tests project takes ~40 seconds. I suspect this is caused by our controller source generator (the project contains a large number of resources). So I explored switching to incremental source generators, until I realized they can only potentially improve IDE IntelliSense performance and don't improve the speed of command-line builds. Furthermore, there are lots of open bugs and some users report a massive increase in memory usage. Therefore I aborted this effort.
I also tried to reduce the number of
Compilationlookups, replacing them with hardcoded qualified type names. But this did not result in measurable performance improvements. These lookups are probably cached inside roslyn.QUALITY CHECKLIST